KMLDataSource issue with non-CORS images

CesiumJS
1

If I try to load a KML with an icon from an external, non-CORS server, the image is not retrieved even though I have my KMLDataSource proxy set. If I add an ‘else’ statement to the following code then it works fine. Am I doing something wrong (do I need a sourceUri as well as a proxy) or is this a DR?

    if (!hrefResolved && defined(sourceUri)) {
        var baseUri = new Uri(document.location.href);
        sourceUri = new Uri(sourceUri);
        href = new Uri(href).resolve(sourceUri.resolve(baseUri)).toString();
        href = proxyUrl(href, proxy);
    }

``

//FIX???
else{
href = proxyUrl(href, proxy);
}

``

2

Sorry I missed this the first time around. I think your code is correct (and in reality we probably just want to move the last line of the if to be outside of the block (then we don’t need the else). I’ll try to write up a test case and get this into the next release.

Thanks for the report (and even better, a solution).