skipLevelOfDetail?

TomPovey · November 27, 2023, 11:08am

this is the relevant PR for anyone interested:

github.com/CesiumGS/cesium

Refactor Cesium3DTileset traversal types into separate classes

CesiumGS:main ← CesiumGS:skip-traversal

opened 05:58PM - 17 Mar 23 UTC

jjhembd

+1118 -858

This PR splits `Cesium3DTilesetTraversal` into two separate classes: `Cesium3DTi…lesetBaseTraversal` and `Cesium3DTilesetSkipTraversal`, which, along with `Cesium3DTilesetMostDetailedTraversal`, are all implementations of the `Cesium3DTilesetTraversal` _interface_. This new structure has the following advantages: - The flow is simpler: branching (based on the tileset.skipLevelOfDetail flag) is done once per frame, instead of several times throughout the traversal - The code is more understandable: each class is easier to read - The new interface is more extensible: to implement new traversal logic, simply add a new class `Cesium3DTilesetNewTraversal` The traversal type is now selected in `Cesium3DTileset.prototype.getTraversal`, instead of being fixed inside `Cesium3DTilePass`. The changes in the traversals themselves are probably easiest to understand by comparing `Cesium3DTilesetBaseTraversal` and `Cesium3DTilesetSkipTraversal` to the original version of `Cesium3DTilesetTraversal`—in this view, each new class is a simplified version of the original.