Custom TerrainProvider broke in 1.104

I have a custom TerrainProvider that grabs terrain data from a local WMS server. It worked fine up to 1.104. I’ve looked at the Change log for 1.104 and cannot find anything that seems to be different in that area.

What happens is as soon as i assign viewer.terrainProvider my custom provider, all imagery and terrain stops loading. I just have a black screen. If I dont assign terrainProvider (or assign it to Cesium WorldTerrain), then map imagery loads fine.

So something in the terrainProvider is blocking the loading of map imagery.

Any tips?

Issue exists in 1.105 too.

the requestTileGeometry function on my TerrainProvider isn’t even being called.

Hi there,

We overhauled how asynchronous behavior was handled in 1.104, and in particular we deprecated the readyPromise property throughout the API.

If your custom terrain provider load any initial metadata, please assign a promise requesting that data to _readyPromise in the constructor. Otherwise, you can set _readyPromise = Promise.resolve(this); in the constructor. This requirement will be removed in 1.107.

Thanks,
Gabby

I already had

this._readyPromise = Promise.resolve(true);
[....]
readyPromise: {
        get: function () {
            return this._readyPromise;
        },
    },

i didn’t have it as Promise.resolve(this) (“this” instead of “true”), but i tried that and still doesn’t work.

I’ve added logging, and i never see the getter called on “ready” or “readyPromise” in 1.104+, but its called all the time in 1.103.

Is there a different way to notify the core that the provider is ready?

Found the solution.

Apparently something in Cesium wants to see a ._ready field of the terrain provider.

Its not enough that you define a ready property getter.

this isn’t documented anywhere. Seems like a problem that there is a dependency on something that starts with a _, which usually indicates its a private member.

created a github issue about the new dependency on undocumented private members