Bug in path visualizer

CesiumJS
1

To sum it up:

var sampleStart;
...

if (hasTrailTime) {
                    sampleStart = JulianDate.addSeconds(time, -trailTime, new JulianDate());
                }

....

if (!hasTrailTime || JulianDate.greaterThan(start, sampleStart)) {
                        sampleStart = start;
                    }

so when hasTrailTime is false it is using a sampleStart variable which is uninitialized causing the render process to stop with an exception.

2

The same issue applies for sampleStop

3

I've patched both like this:

if (!hasTrailTime || !defined(sampleStart) || JulianDate.greaterThan(start, sampleStart)) {
                        sampleStart = start;
                    }

                    if (!hasLeadTime || !defined(sampleStop) || JulianDate.lessThan(stop, sampleStop)) {
                        sampleStop = stop;
                    }

is this correct?